Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1791 / add locale-appropriate formatting to historical stats numbers #498

Merged
merged 2 commits into from Feb 13, 2020
+5 −5
Merged

GH-1791 / add locale-appropriate formatting to historical stats numbers #498

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c53ca7
Add locale-appropriate formatting to historical stat numbers
wlycdgr Feb 11, 2020
581ac85
small lintfix in Settings/OptIn component
wlycdgr Feb 11, 2020
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next
Loading status checks…

Add locale-appropriate formatting to historical stat numbers

  • Loading branch information
@wlycdgr
wlycdgr committed Feb 11, 2020
commit 0c53ca7678dfae085adfab6594ad3c8038f9b071
8 app/panel/components/StatsView.jsx
View file
Open in desktop
@@ -147,31 +147,31 @@ const StatsView = (props) => {
<div id="trackersSeen" className={tile} onClick={selectView}>
<div className="tile-title"><p className={trackersSeenClassNames}>{t('panel_stats_trackers_seen')}</p></div>
<div className={trackersSeenValueClassNames}>
<p className="tile-value-content">{subscriber ? trackersSeen : ''}</p>
<p className="tile-value-content">{subscriber ? trackersSeen.toLocaleString() : ''}</p>
<div className="active-underline" />
</div>
</div>
<div className="tile-divider" />
<div id="trackersBlocked" className={tile} onClick={selectView}>
<div className="tile-title"><p className={trackersBlockedClassNames}>{t('panel_stats_trackers_blocked')}</p></div>
<div className={trackersBlockedValueClassNames}>
<p className="tile-value-content">{subscriber ? trackersBlocked : ''}</p>
<p className="tile-value-content">{subscriber ? trackersBlocked.toLocaleString() : ''}</p>
<div className="active-underline" />
</div>
</div>
<div className="tile-divider" />
<div id="trackersAnonymized" className={tile} onClick={selectView}>
<div className="tile-title"><p className={trackersAnonymizedClassNames}>{t('panel_stats_trackers_anonymized')}</p></div>
<div className={trackersAnonymizedValueClassNames}>
<p className="tile-value-content">{subscriber ? trackersAnonymized : ''}</p>
<p className="tile-value-content">{subscriber ? trackersAnonymized.toLocaleString() : ''}</p>
<div className="active-underline" />
</div>
</div>
<div className="tile-divider" />
<div id="adsBlocked" className={tile} onClick={selectView}>
<div className="tile-title"><p className={adsBlockedClassNames}>{t('panel_stats_ads_blocked')}</p></div>
<div className={adsBlockedValueClassNames}>
<p className="tile-value-content">{subscriber ? adsBlocked : ''}</p>
<p className="tile-value-content">{subscriber ? adsBlocked.toLocaleString() : ''}</p>
<div className="active-underline" />
</div>
</div>
ProTip! Use n and p to navigate between commits in a pull request.