Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for UI bugs in Ghostery panel related to longer strings in German language (GH-869, GH-870, GH-872) #5

Merged
merged 5 commits into from Mar 15, 2018
Merged

Fixes for UI bugs in Ghostery panel related to longer strings in German language (GH-869, GH-870, GH-872) #5

merged 5 commits into from Mar 15, 2018

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Mar 12, 2018 •
edited

  • [x ] Have you followed the guidelines in CONTRIBUTING.md?
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Have you added an explanation of what your changes do?
  • [x ] Does your submission pass tests?
  • [x ] Did you lint your code prior to submission?

This submission addresses UI bugs in Ghostery panel related to longer strings in German language (GH-869, GH-870, GH-872)
Serge Zarembsky added 2 commits Mar 12, 2018
Serge Zarembsky
Fixes for GH-869, GH-870.
8318f2c
Serge Zarembsky
Merge remote-tracking branch 'upstream/develop' into develop
Loading status checks…
c3fb116
@zarembsky zarembsky requested a review from ghostery/ghostery as a code owner Mar 12, 2018
@zarembsky zarembsky changed the title Develop Fixes for UI bugs in Ghostery panel related to longer strings in German language (GH-869, GH-870) Mar 13, 2018
Serge Zarembsky added 2 commits Mar 13, 2018
Serge Zarembsky
Fix for GH-872
Loading status checks…
eb3baea
Serge Zarembsky
Fixing lint errors.
Loading status checks…
9680394
@zarembsky zarembsky requested review from christophertino and removed request for christophertino Mar 13, 2018
@zarembsky zarembsky changed the title Fixes for UI bugs in Ghostery panel related to longer strings in German language (GH-869, GH-870) Fixes for UI bugs in Ghostery panel related to longer strings in German language (GH-869, GH-870, GH-872) Mar 13, 2018
@trickpattyFH20
trickpattyFH20 approved these changes Mar 13, 2018
View changes
Serge Zarembsky
Adding callouts for tooltips.
Loading status checks…
2de44bb
@christophertino christophertino merged commit e6b768e into ghostery:develop Mar 15, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wlycdgr wlycdgr mentioned this pull request Feb 28, 2019
Closed
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trickpattyFH20 trickpattyFH20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@zarembsky @trickpattyFH20 @christophertino