Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1477 Wildcard/Regex Whitelisting #501

Merged
merged 8 commits into from Mar 3, 2020
Merged

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Feb 25, 2020

  • [*] Have you followed the guidelines in CONTRIBUTING.md?
  • [*] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [*] Have you added an explanation of what your changes do?
  • [*] Does your submission pass tests?
  • [*] Did you lint your code prior to submission?

Ticket: https://cliqztix.atlassian.net/browse/GH-1477

@benstrumeyer benstrumeyer requested review from christophertino, Eden12345, jsignanini, zarembsky and ghostery/ghostery as code owners Feb 25, 2020
Copy link
Contributor

@Eden12345 Eden12345 left a comment

You're requesting to merge this branch into master rather than develop in this PR

@benstrumeyer benstrumeyer changed the base branch from master to develop Feb 25, 2020
@christophertino christophertino added this to the 8.4.7 milestone Feb 25, 2020
@benstrumeyer benstrumeyer requested a review from Eden12345 Feb 25, 2020
Copy link
Member

@christophertino christophertino left a comment

In my testing, a whitelist entry for ghostery.com will whitelist signon.ghostery.com, however it also will catch someotherghostery.com. If there are no wildcard or regex characters in the string we should strict match

src/classes/Policy.js Outdated Show resolved Hide resolved
@benstrumeyer benstrumeyer requested a review from christophertino Feb 27, 2020
@benstrumeyer benstrumeyer requested a review from christophertino Mar 3, 2020
@christophertino christophertino merged commit 79bf18f into develop Mar 3, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the feature/regex-whitelisting branch Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants