GH-1969 Plus In App Promo & GH-1970 Telemetry #509
Merged
Conversation
…ModalContent out to shared-components
|
"No thanks, continue with Basic" does not dismiss the Midnight promo modal in the Hub |
|
(Come to think of it, is the user even still supposed to see the Midnight promo modal in the Hub?) |
| // Should we send a plus ping here? | ||
| // sendMessage('ping', 'promo_modals_plus_upgrade_cta'); | ||
| url = `https://checkout.${DOMAIN}.com/plus?utm_source=gbe&utm_campaign=${utm_campaign}`; | ||
| break; | ||
| case PREMIUM: | ||
| url = `https://ghostery.com/thanks-for-downloading-midnight?utm_source=gbe&utm_campaign=${utm_campaign}`; | ||
| break; |
Comment on lines
79
to
85
wlycdgr
Apr 13, 2020
Member
Should we send promo_modals_[modal_type]_upgrade_cta pings for plus and for premium like we do for insights?
Should we send promo_modals_[modal_type]_upgrade_cta pings for plus and for premium like we do for insights?
benstrumeyer
Apr 15, 2020
Author
Contributor
Holding off on adding extra pings for now per teresa
Holding off on adding extra pings for now per teresa
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Tickets: https://cliqztix.atlassian.net/browse/GH-1969, https://cliqztix.atlassian.net/browse/GH-1970