Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1969 Plus In App Promo & GH-1970 Telemetry #509

Merged
merged 18 commits into from Apr 20, 2020
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Remove comments and console.logs

  • Loading branch information
benstrumeyer committed Mar 9, 2020
commit 887f445bcd17094b19e49a0389c6c2214ef41a36
@@ -253,7 +253,6 @@ class Panel extends React.Component {
_handlePromoTryPlusClick = () => {
this.props.actions.togglePromoModal();

// Add utm params
const url = `https://checkout.${DOMAIN}.com/plus?utm_source=gbe&utm_campaign=in_app_spring2020`;
sendMessage('openNewTab', {
url,
@@ -302,7 +301,6 @@ class Panel extends React.Component {
* Handle clicks on the 'X' close icon in promo modals
*/
_handlePromoXClick = (modal) => {
console.log('handling x click');
this.props.actions.togglePromoModal();

if (modal === 'insights') {
@@ -34,8 +34,6 @@ $condensed-font-family: Roboto Condensed, "Open Sans", "Helvetica Neue", Helveti
.PlusPromoModal__main-content-container {
height: 210px;
display: flex;
// flex-direction: column;
// align-items: center;
justify-content: center;
}
.PlusPromoModal__header {
@@ -990,7 +990,6 @@ function onMessageHandler(request, sender, callback) {
return false;
}
if (name === 'promoModals.turnOffPromos') {
console.log('turning off promos');
promoModals.turnOffPromos();
return false;
}
@@ -99,10 +99,8 @@ class PromoModals {
*/
static _hasEngagedFrequently() {
const { engaged_daily_count } = conf.metrics || [];
console.log(engaged_daily_count);

const very_engaged_days = engaged_daily_count.reduce((acc, count) => (count >= DAILY_INSIGHTS_TARGET ? ++acc : acc), 0);
console.log('very engaged days: ', very_engaged_days);

return very_engaged_days >= WEEKLY_INSIGHTS_TARGET;
}
ProTip! Use n and p to navigate between commits in a pull request.