Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-1969 Plus In App Promo & GH-1970 Telemetry #509
GH-1969 Plus In App Promo & GH-1970 Telemetry #509
Changes from 1 commit
d7a2d6d95280ff887f445c14cf556301df3bedad1004a976031121c12b5497270c9fa156d07164f187afea8f83fe3140f5121cafb406fec5e6771a416ed0d1File filter
Jump to
Design spring-plus promo modal
Large diffs are not rendered by default.
Eden12345Mar 23, 2020
Contributor
Looks like this comment needs to be updated
benstrumeyerMar 31, 2020
Author
Contributor
Updated comment!
Eden12345Mar 23, 2020
•
edited
Contributor
Won't
this._handlePromoSubscribeClickopen the checkout for Premium rather than Plus, since it's just the checkout URL (which automatically redirects to Premium from what I can see)?benstrumeyerApr 7, 2020
Author
Contributor
fixed!
Eden12345Mar 23, 2020
Contributor
Is there a way we could combine
PlusPromoModal,InsightsPromoModal, andPremiumPromoModal, or at least wrap them all in the same outer component that takes care of the functions that are essential to each (eg.handleGoAwayClick,handleSignInClick,handleXClick)?wlycdgrApr 13, 2020
Member
See my comment on
ModalExitButtonto make sure that thisgreyclass gets applied when needed.benstrumeyerApr 15, 2020
Author
Contributor
Good idea, we can just apply the value of border here