Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Transifex Client config file. #51

Merged
merged 11 commits into from May 10, 2018
Merged

Adding Transifex Client config file. #51

merged 11 commits into from May 10, 2018

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented May 8, 2018

  • [x ] Have you followed the guidelines in CONTRIBUTING.md?
  • [ x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Have you added an explanation of what your changes do?
  • [x ] Does your submission pass tests?
  • [x ] Did you lint your code prior to submission?
Serge Zarembsky added 2 commits May 4, 2018
Serge Zarembsky
@zarembsky zarembsky requested a review from ghostery/ghostery as a code owner May 8, 2018
Serge Zarembsky added 3 commits May 8, 2018
Serge Zarembsky
Serge Zarembsky
Serge Zarembsky
@zarembsky zarembsky requested a review from christophertino May 9, 2018
README.md Outdated
```sh
# Install Transifex Client (tx)
$ pip install transifex-client
# Check if install was successful

This comment has been minimized.

@jsignanini

jsignanini May 10, 2018
Member

@zarembsky looks like there's a tx init command that needs to be run to set up the tx command line tool. Please add instructions on how to set this up.

Serge Zarembsky added 2 commits May 10, 2018
@jsignanini
Copy link
Member

@jsignanini jsignanini commented May 10, 2018

@zarembsky On second thought, since we're a public repo now, let's not add these instructions to the README since it will be misleading to a user that's not part of our internal dev team. Let's just undo all README.md changes.

zarembsky and others added 4 commits May 10, 2018
@jsignanini jsignanini merged commit 6046e98 into develop May 10, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the feature/txgh branch May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants