Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1967 Themes Panel Update #510

Merged
merged 7 commits into from Apr 14, 2020
Merged

GH-1967 Themes Panel Update #510

merged 7 commits into from Apr 14, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Mar 12, 2020

  • [*] Have you followed the guidelines in CONTRIBUTING.md?
  • [*] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [*] Have you added an explanation of what your changes do?
  • [*] Does your submission pass tests?
  • [*] Did you lint your code prior to submission?
  • Change theme toggle to radio buttons inside panel
  • Visually changes "Midnight Theme" to "Dark Blue Theme"
    • Variable name changes will be reflected in GH-1974 and GIS-545
  • Add palm/leaf theme radio buttons that currently do nothing

Ticket: https://cliqztix.atlassian.net/browse/GH-1967
@benstrumeyer
Replace themes toggle with radio buttons
317ab64
@benstrumeyer
Center inner circle in radio buttons
Loading status checks…
f050b83
@benstrumeyer
Merge branch 'develop' into GH-1967/themes-panel-update
Loading status checks…
e8d7f92
@benstrumeyer benstrumeyer requested a review from christophertino Mar 12, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner Mar 12, 2020
@benstrumeyer benstrumeyer added this to the 8.4.8 milestone Mar 12, 2020
@benstrumeyer
Remove console error
Loading status checks…
f9b1546
@benstrumeyer benstrumeyer requested a review from Eden12345 Mar 16, 2020
@Eden12345
Eden12345 suggested changes Mar 23, 2020
View changes
app/panel/components/BuildingBlocks/RadioButtonGroup.jsx Outdated Show resolved Hide resolved
app/scss/partials/_radio_button.scss Outdated Show resolved Hide resolved
app/scss/partials/_radio_button.scss Outdated Show resolved Hide resolved
@christophertino christophertino modified the milestones: 8.4.8, 8.5.0 Mar 25, 2020
@benstrumeyer
Clean up radio button code
2a8bce2
@benstrumeyer
Merge branch 'develop' into GH-1967/themes-panel-update
Loading status checks…
d0ec9be
@benstrumeyer benstrumeyer requested a review from Eden12345 Mar 31, 2020
@Eden12345
Eden12345 approved these changes Mar 31, 2020
View changes
@benstrumeyer benstrumeyer mentioned this pull request Apr 6, 2020
Closed
5 of 5 tasks complete
@benstrumeyer benstrumeyer mentioned this pull request Apr 14, 2020
Merged
5 of 5 tasks complete
@christophertino
Merge branch 'develop' into GH-1967/themes-panel-update
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
c90b51a
@christophertino
christophertino approved these changes Apr 14, 2020
View changes
@christophertino christophertino merged commit 1719e45 into develop Apr 14, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-1967/themes-panel-update branch Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@Eden12345 Eden12345

Assignees
No one assigned
Labels
Type: Feature Enhancement
Projects
None yet
Milestone
8.5.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @christophertino @Eden12345