Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template all base urls in Globals.js #511

Merged
merged 10 commits into from Apr 14, 2020
Merged

Template all base urls in Globals.js #511

merged 10 commits into from Apr 14, 2020

Conversation

@fcjr
Copy link
Member

@fcjr fcjr commented Mar 13, 2020

This adds two new globals COOKIE_URL and COOKIE_DOMAIN and moves all of the templating other ghostery baseURLs into the globals file so that .com and https are not hardcoded all over the extension and instead are consolidated into one place to make it easier to run the extension in local testing envrionments.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@fcjr fcjr requested review from christophertino, Eden12345, jsignanini, zarembsky and ghostery/ghostery as code owners Mar 13, 2020
@fcjr fcjr changed the base branch from master to develop Mar 13, 2020
@fcjr fcjr changed the title Move's cookie urls to Globals Moves cookie urls to Globals Mar 16, 2020
fcjr added 2 commits Mar 16, 2020
@fcjr fcjr changed the title Moves cookie urls to Globals Template all FQDNs in Globals.js Mar 17, 2020
fcjr added 2 commits Mar 17, 2020
@fcjr fcjr changed the title Template all FQDNs in Globals.js Template all base urls in Globals.js Mar 18, 2020
@christophertino christophertino added this to the 8.4.8 milestone Mar 18, 2020
src/classes/Globals.js Show resolved Hide resolved
@fcjr fcjr requested a review from jsignanini Mar 18, 2020
@christophertino christophertino modified the milestones: 8.4.8, 8.5.0 Mar 25, 2020
fcjr and others added 2 commits Mar 27, 2020
@christophertino christophertino merged commit 3f1c8ea into develop Apr 14, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the global_cookie_url branch Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants