Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1975 Theme Framework & GH-1972 Palm Theme #517

Closed
wants to merge 22 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Adding comments.
  • Loading branch information
zarembsky committed Mar 19, 2020
commit 8a66ff9e8e131050d4e2f8e067810dd8ad24811c
@@ -0,0 +1,7 @@
1. Two theme scss files palm-theme.scss and midnight-theme.scss are added under app\scss
2. Couple of lines in .\webpack.config.js ensure the themes are compiled as the rest of SCSS files.
They end up in dist\css as palm_theme.css and midnight_theme.css. Will refer to them by file paths.
3. In src\classes\account.js getTheme function mimics the original, but returns file paths instead of
css stream.
4. In app\panel\utils\utils.js setTheme function is changed to add <link rel="stylesheet" href={path_to_theme}/>
element instead of inline <style> element.
ProTip! Use n and p to navigate between commits in a pull request.