Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1975 Theme Framework & GH-1972 Palm Theme #520

Closed
wants to merge 31 commits into from

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Mar 31, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • This PR accounts for moving the theme framework into the account project and addresses changes in #517
@benstrumeyer benstrumeyer requested review from christophertino, wlycdgr, zarembsky and ghostery/ghostery as code owners Mar 31, 2020
Copy link
Contributor

@Eden12345 Eden12345 left a comment

If I'm not mistaken, it looks like you're committing our actual bugs.json database to the repository.

Does the leaf.svg have to be 83,955 lines to load the image properly? If so, we may not be able to use an SVG for this image. It looks like you're also committing a leaf.png file; if this is the same image, can we just use that? Either way, I believe this file is supposed to be passed to the Ghostery Extension from the Account project, so should it be removed from this PR altogether?

Lastly, the RadioButtonGroup.jsx file in this PR has been edited quite a bit in your #510 PR after some requested changes there, and I just want to make sure that you're planning on merging those changes into this branch before merging this one.

@benstrumeyer benstrumeyer deleted the feature/palm-theme branch Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants