Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1989: Fixes site-specific whitelisting for unblocked trackers #522

Merged
merged 5 commits into from Apr 14, 2020

Conversation

christophertino
Copy link
Contributor

@christophertino christophertino commented Apr 2, 2020

Previously if a tracker was unblocked, setting site-specific allow would not be honored.

Bump version number and npm dependencies.

Fixes #519

Added unit tests: yarn test.unit test/src/policy.test.js

@christophertino christophertino added this to the 8.5.0 milestone Apr 2, 2020
@christophertino christophertino requested review from jsignanini and a team April 2, 2020 15:57
@christophertino christophertino changed the base branch from master to develop April 2, 2020 15:58
@christophertino christophertino merged commit e3fa7be into develop Apr 14, 2020
@christophertino christophertino deleted the GH-1989 branch April 14, 2020 18:13
chrmod pushed a commit that referenced this pull request Jul 28, 2022
* GH-1989: Fixes #519 site-specific whitelisting for unblocked trackers. Update npm dependencies

* add unit tests for policy.shouldBlock()

* bump eslint loader version
chrmod pushed a commit that referenced this pull request Jul 29, 2022
* GH-1989: Fixes #519 site-specific whitelisting for unblocked trackers. Update npm dependencies

* add unit tests for policy.shouldBlock()

* bump eslint loader version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tealium's utag.js is being blocked by Ghostery even when allowed on the site
1 participant