Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic version compare #524

Merged
merged 2 commits into from Apr 9, 2020
+174 −77
Merged

Semantic version compare #524

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fe1275
Compare semantic versions properly. Add unit tests. Update AMO build …
christophertino Apr 8, 2020
005898e
add check for version history length
christophertino Apr 8, 2020
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev
Loading status checks…

add check for version history length

  • Loading branch information
@christophertino
christophertino committed Apr 8, 2020
commit 005898e1bdef1f0d3d9a3cca0c5d1ad737ff9bf8
2 src/background.js
View file
Open in desktop
@@ -1490,7 +1490,7 @@ function initializeVersioning() {
}

// Check if the earliest version is < 8.4.2
if (utils.semverCompare(versions[0], '8.4.2') === -1) {
if (versions.length && utils.semverCompare(versions[0], '8.4.2') === -1) {
globals.REQUIRE_LEGACY_OPT_IN = true;
}

ProTip! Use n and p to navigate between commits in a pull request.