Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-1975 Theme Framework, Leaf & Palm Themes (FINAL) #525
GH-1975 Theme Framework, Leaf & Palm Themes (FINAL) #525
Changes from 1 commit
317ab64f050b83e8d7f92f9b1546a9a12aafc6149405a37b30e0beef8a66ff91ff8eb460cfc9105f8718824b2a3d36fd1a260c6278660643d22b7520fb546b2a8bce22a58c2937829c92e44e44fc1a2a31bbc72dd0ec9bebc90f185350c2bc1748ddfeb29b0f08ff586bf02dd233d77402671ef5bf89029334ab75a348ba8805349d490c4bf1aae4510e7c01a2c4c53f9eb0e134e18313c44fef95b1c136f864d8851974792842cb2d9b216dd4c78b03e8512174bf86deb06ea5a43ce1a76dfc5730a29b4b39c20File filter
Jump to
Real fix
wlycdgrApr 14, 2020
Member
Remove or correct this comment (and also let's move the previous one at the start of the function down to the appropriate place)
benstrumeyerApr 15, 2020
Author
Contributor
Updated comment to "Get style tag for the active theme", and moved the first comment
wlycdgrApr 14, 2020
Member
We can remove this comment and replace with the tidier
forEach, which is now supported in all our supported browser versionsbenstrumeyerApr 15, 2020
Author
Contributor
Good to know, changed to a forEach loop
benstrumeyerApr 15, 2020
•
edited
Author
Contributor
I stand corrected, we're unable to use a regular forEach loop because getElementsByTagName returns an HTML collection. I've changed it to
Array,prototype.forEach.call(styleList, (style) => {...})as suggested by the following stackoverflow thread unless you think keeping a basic for loop is cleaner. Thoughts?https://stackoverflow.com/questions/39797101/why-cant-i-use-array-foreach-on-a-collection-of-javascript-elements
wlycdgrApr 15, 2020
Member
Ah dang, right, sorry. We can use
Array.from(styleList).forEach