Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1979 Allow user selection of Ad Block filter lists #527

Merged
merged 5 commits into from Apr 21, 2020
Merged

Conversation

@christophertino
Copy link
Member

@christophertino christophertino commented Apr 17, 2020

Adds a new component in the Settings panel with Ad Blocker list selection options.

Fixes #504

@christophertino christophertino added this to the 8.5.0 milestone Apr 17, 2020
@christophertino christophertino requested a review from remusao Apr 17, 2020
@christophertino christophertino requested review from wlycdgr, zarembsky and ghostery/ghostery as code owners Apr 17, 2020
Copy link
Contributor

@benstrumeyer benstrumeyer left a comment

Tested, and looks good to me

Copy link
Member

@wlycdgr wlycdgr left a comment

Just the one minor comment

app/panel/components/Settings/SettingsMenu.jsx Outdated Show resolved Hide resolved
@christophertino christophertino requested a review from wlycdgr Apr 20, 2020
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM

@christophertino christophertino merged commit d479c2b into develop Apr 21, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-1979 branch Apr 21, 2020
@yokoffing
Copy link

@yokoffing yokoffing commented May 18, 2020

Thank you for finally implementing this! I feel more confident in recommending Ghostery now that annoyances are being addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants