Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1969, GH-2029 Plus & Premium In App Promo's #529

Closed
wants to merge 24 commits into from
Closed

GH-1969, GH-2029 Plus & Premium In App Promo's #529

wants to merge 24 commits into from

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Apr 23, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Addresses copy changes in GH-1969 and GH-2029 in the Plus and Premium Promo Modals
  • Slipped in slight CSS changes that keeps the first Premium feature on one line
benstrumeyer and others added 20 commits Mar 5, 2020
@benstrumeyer
Design spring-plus promo modal
Loading status checks…
d7a2d6d
@benstrumeyer
Add click events to promo modal
Loading status checks…
95280ff
@benstrumeyer
Remove comments and console.logs
Loading status checks…
887f445
@benstrumeyer
Add translations
Loading status checks…
c14cf55
@benstrumeyer
Unfinished PromoModal superclass
6301df3
@benstrumeyer
Add base class for promo modals
bedad10
@benstrumeyer
Insights promo modal broken
Loading status checks…
04a9760
@Eden12345
Fix handlePromoXClick, comment in PromoModal structure
Loading status checks…
31121c1
@benstrumeyer
Merge insights, plus, and premium PromoModal methods
Loading status checks…
2b54972
@benstrumeyer
Fix error
Loading status checks…
70c9fa1
@benstrumeyer
Refactor X button out to PromoModal.jsx. Move Insights and Plus Promo…
Loading status checks…
56d0716 
…ModalContent out to shared-components
@benstrumeyer
Fix imports and remove debug flag from manifest.json
Loading status checks…
4f187af
@Eden12345
Use React.Fragment, update class names, factor out repeat code, updat…
Loading status checks…
ea8f83f 
…e lint file
@Eden12345
Update InsightsPromoModal class name and fix display
Loading status checks…
e3140f5
@benstrumeyer
Merge branch 'develop' into GH-1969/plus-in-app-promo
121cafb
@benstrumeyer
Fix premium promo modal in hub. Refactor promo modal pings. Style mod…
Loading status checks…
406fec5 
…al exit button.
@benstrumeyer
Merge branch 'develop' into GH-1969/plus-in-app-promo
Loading status checks…
e6771a4
@benstrumeyer
Merge branch 'develop' into GH-1969/plus-in-app-promo
Loading status checks…
16ed0d1
@benstrumeyer
Change Spring has sprung to Spring is here. Clear them when logging out
3f8f5dd
@benstrumeyer
Change Plus promo modal copy
5e8dd16
@benstrumeyer benstrumeyer requested review from christophertino, Eden12345, jsignanini, wlycdgr, zarembsky and ghostery/ghostery as code owners Apr 23, 2020
@benstrumeyer benstrumeyer changed the base branch from master to develop Apr 23, 2020
@benstrumeyer benstrumeyer deleted the GH-1969/plus-in-app-promo branch Apr 23, 2020
@benstrumeyer
Remove $2 price tag from Plus Promo
e771e4f
@benstrumeyer
Remove $14 price tag from Premium Promo
6606256
@benstrumeyer
Merge branch 'develop' into GH-1969/plus-in-app-promo
Loading status checks…
72df836
@benstrumeyer
Remove testing code
Loading status checks…
73d08e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@Eden12345 Eden12345

@jsignanini jsignanini

@wlycdgr wlycdgr

@zarembsky zarembsky

@ghostery/ghostery Ghostery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@benstrumeyer @Eden12345