Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1969, GH-2029 Plus & Premium In App Promo's #530

Merged
merged 4 commits into from Apr 26, 2020
Merged

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Apr 23, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Addresses copy changes in GH-1969 and GH-2029 in the Plus and Premium Promo Modals
  • Slipped in slight CSS changes that keeps the first Premium feature on one line

Tickets:

@benstrumeyer benstrumeyer added this to the 8.5.0 milestone Apr 23, 2020
@benstrumeyer benstrumeyer requested review from wlycdgr and Eden12345 Apr 23, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner Apr 23, 2020
@benstrumeyer benstrumeyer self-assigned this Apr 23, 2020
Copy link
Member

@wlycdgr wlycdgr left a comment

2 things -

  • Does the sign in link copy also need to be updated as per GH-1969?
  • I remember that a bunch of the CSS decisions for the Premium modal were compromises to make sure that the modal didn't look too bad/broken across any of the languages we support - that is part of why it looks sub-optimal in English. If you haven't yet, make sure these changes don't break the layout in languages like German and Russian.
@benstrumeyer benstrumeyer requested a review from wlycdgr Apr 23, 2020
…re text to one line
@christophertino christophertino merged commit 19cb752 into develop Apr 26, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-1969/fix branch Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants