Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1969, GH-2029 Plus & Premium In App Promo's #530

Merged
merged 4 commits into from Apr 26, 2020
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Change sign in link copy
  • Loading branch information
benstrumeyer committed Apr 24, 2020
commit 645c228a19aca780bafac587c161803585f068e2
@@ -1832,6 +1832,9 @@
"subscribe_pitch_sign_here": {
"message": "Already a subscriber? Sign in here"
},
"subscribe_pitch_sign_in_plus": {
"message": "Already a subscriber? Sign in"
},
"subscribe_pitch_sign_in": {
"message": "Already subscribed? Sign in"
},
@@ -2367,9 +2370,6 @@
"message": "Already subscribed? Sign In",
"description": "Character limit (including spaces and punctuation): 28."
},
"already_subscribed_to_plus_sign_in": {
"message": "Already a plus subscriber?"
},
"promos_turned_off_notification": {
"message": "Promos turned off. You can turn them back on in",
"description": "translation must take into account that 'Settings' is appended to this string"
@@ -48,7 +48,7 @@ const PlusPromoModalContent = (props) => {
</div>
<div>
{!loggedIn &&
<span className="PlusPromoModal__link sign-in" onClick={handleSignInClick}>{t('already_subscribed_to_plus_sign_in')}</span>
<span className="PlusPromoModal__link sign-in" onClick={handleSignInClick}>{t('subscribe_pitch_sign_in_plus')}</span>
}
<span className="PlusPromoModal__link turn-promos-off" onClick={handleGoAwayClick}>{t('no_thanks_turn_promos_off')}</span>
</div>
@@ -57,7 +57,6 @@ const PlusPromoModalContent = (props) => {
);
};


// PropTypes ensure we pass required props of the correct type
PlusPromoModalContent.propTypes = {
handleTryPlusClick: PropTypes.func.isRequired,
@@ -7,6 +7,7 @@
"version_name": "8.5.0",
"default_locale": "en",
"description": "__MSG_short_description__",
"debug": true,
"log": true,
"icons": {
"16": "app/images/icon16.png",
ProTip! Use n and p to navigate between commits in a pull request.