Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1969, GH-2029 Plus & Premium In App Promo's #530

Merged
merged 4 commits into from Apr 26, 2020
Merged
Changes from all commits
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

@@ -1818,7 +1818,7 @@
"message": "While Ghostery is free, you can choose to support us through a small subscription of $2 per month in exchange for cool perks, such as color themes, priority help service, and more. Join our mission and subscribe!"
},
"subscribe_pitch_spring": {
"message": "Support us and unlock a new spring theme, personal tracking insights, and other special perks by upgrading to Ghostery Plus for $2 per month."
"message": "Like what we do? Support us and unlock new spring themes, personal tracking insights, and other special perks by upgrading to Ghostery Plus"
},
"subscribe_pitch_learn_more": {
"message": "Learn more"
@@ -1832,6 +1832,9 @@
"subscribe_pitch_sign_here": {
"message": "Already a subscriber? Sign in here"
},
"subscribe_pitch_sign_in_plus": {
"message": "Already a subscriber? Sign in"
},
"subscribe_pitch_sign_in": {
"message": "Already subscribed? Sign in"
},
@@ -2367,9 +2370,6 @@
"message": "Already subscribed? Sign In",
"description": "Character limit (including spaces and punctuation): 28."
},
"already_subscribed_to_plus_sign_in": {
"message": "Already a plus subscriber?"
},
"promos_turned_off_notification": {
"message": "Promos turned off. You can turn them back on in",
"description": "translation must take into account that 'Settings' is appended to this string"
@@ -2381,10 +2381,10 @@
"message": "Try Ghostery Midnight"
},
"seven_day_free_trial": {
"message": "7 Day Free Trial ($14/mo)"
"message": "7 Day Free Trial"
},
"spring_has_sprung": {
"message": "Spring has sprung!"
"spring_is_here": {
"message": "Spring is here!"
},
"full_coverage_protection_promise": {
"message": "Get full-coverage protection across all browsers & apps on your device"
@@ -2404,8 +2404,8 @@
"download_for_free": {
"message": "Download for free"
},
"support_ghostery_for_2_instead": {
"message": "Support Ghostery for $2/mo instead"
"support_ghostery_and_try_plus_instead": {
"message": "Support Ghostery and try Plus instead"
},
"no_thanks_continue_with_basic": {
"message": "No thanks, continue with basic"
@@ -33,7 +33,7 @@ const PlusPromoModalContent = (props) => {
<div className="PlusPromoModal__main-content-container">
<div className="PlusPromoModal__header">
<div className="title">
<div>{t('spring_has_sprung')}</div>
<div>{t('spring_is_here')}</div>
</div>
<div className="description">
<div dangerouslySetInnerHTML={{ __html: t('subscribe_pitch_spring') }} />
@@ -48,7 +48,7 @@ const PlusPromoModalContent = (props) => {
</div>
<div>
{!loggedIn &&
<span className="PlusPromoModal__link sign-in" onClick={handleSignInClick}>{t('already_subscribed_to_plus_sign_in')}</span>
<span className="PlusPromoModal__link sign-in" onClick={handleSignInClick}>{t('subscribe_pitch_sign_in_plus')}</span>
}
<span className="PlusPromoModal__link turn-promos-off" onClick={handleGoAwayClick}>{t('no_thanks_turn_promos_off')}</span>
</div>
@@ -57,7 +57,6 @@ const PlusPromoModalContent = (props) => {
);
};


// PropTypes ensure we pass required props of the correct type
PlusPromoModalContent.propTypes = {
handleTryPlusClick: PropTypes.func.isRequired,
@@ -80,7 +80,7 @@ const PremiumPromoModalContent = (props) => {
</div>
<div className="PremiumPromoModal__text-link-container">
{!isPlus && (
<div onClick={handleGetPlusClick} className="PremiumPromoModal__text-link" dangerouslySetInnerHTML={{ __html: t('support_ghostery_for_2_instead') }} />
<div onClick={handleGetPlusClick} className="PremiumPromoModal__text-link" dangerouslySetInnerHTML={{ __html: t('support_ghostery_and_try_plus_instead') }} />
)}
{isInHub && (
<div onClick={handleKeepBasicClick} className="PremiumPromoModal__text-link">
@@ -32,7 +32,7 @@ $condensed-font-family: Roboto Condensed, "Open Sans", "Helvetica Neue", Helveti
}

.PremiumPromoModal__main-content-container {
height: 210px;
height: 210px;
display: flex;
flex-direction: column;
align-items: center;
ProTip! Use n and p to navigate between commits in a pull request.