Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1967 Clear theme on logout #531

Merged
merged 2 commits into from Apr 26, 2020
Merged

GH-1967 Clear theme on logout #531

merged 2 commits into from Apr 26, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Apr 23, 2020 •
edited

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Addresses kickback on GH-1967, theme now clears on logout and not on panel-reopen

Ticket: https://cliqztix.atlassian.net/browse/GH-1967
@benstrumeyer benstrumeyer added this to the 8.5.0 milestone Apr 23, 2020
@benstrumeyer benstrumeyer requested review from wlycdgr and Eden12345 Apr 23, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner Apr 23, 2020
@benstrumeyer benstrumeyer self-assigned this Apr 23, 2020
@Eden12345
Eden12345 approved these changes Apr 23, 2020
View changes
benstrumeyer and others added 2 commits Apr 24, 2020
@benstrumeyer
Clear theme on logout
Loading status checks…
3b2a8ca
@christophertino
Merge branch 'develop' into GH-1967/fix
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
5ecb9e9
@christophertino christophertino merged commit c25a168 into develop Apr 26, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-1967/fix branch Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eden12345 Eden12345

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @Eden12345 @christophertino