GH 1960 & GH-2028 ForgotPassword Hub Error Message and Loading Icon Fix #533
Conversation
| const { locale } = this.props; | ||
| const isInPanel = locale === 'panel'; | ||
| const isInHub = locale === 'hub'; |
Comment on lines
89
to
+91
Eden12345
Apr 24, 2020
•
Contributor
I know this wasn't added in this PR either, just wanted to point out that it's a rather confusing choice semantically to use "locale" for the variable name for which view we're in when we also have locales for translations.
I know this wasn't added in this PR either, just wanted to point out that it's a rather confusing choice semantically to use "locale" for the variable name for which view we're in when we also have locales for translations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.


This PR addresses GH-1960 kickbacks
Tickets: