Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH 1960 & GH-2028 ForgotPassword Hub Error Message and Loading Icon Fix #533

Merged
merged 4 commits into from Apr 26, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Apr 24, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

This PR addresses GH-1960 kickbacks

  • Forgot Password cancel button in the hub now redirects to log in screen
  • A toast is shown when a user enters an email we don't have in our system
  • Move loading icon scss to a partials directory to be used in panel and hub

Tickets:

@benstrumeyer benstrumeyer added this to the 8.5.0 milestone Apr 24, 2020
@benstrumeyer benstrumeyer requested review from wlycdgr and Eden12345 Apr 24, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner Apr 24, 2020
@benstrumeyer benstrumeyer self-assigned this Apr 24, 2020
Copy link
Contributor

@Eden12345 Eden12345 left a comment

I know this was not part of this PR, but I noticed when testing this that the design of the Forgot Password view is completely out of sync with the rest of the Account views in the Hub. See the screenshots below for reference.

Sign In view (an example of the correct design pattern for the Hub):
Screen Shot 2020-04-24 at 3 06 56 PM

Forgot Password view (button colors are wrong, the input field has the wrong border radius and box shadow, the loading state changes the size of the submit button, and it isn't centered in the view overall):
Screen Shot 2020-04-24 at 3 05 49 PM

Since this wasn't what this PR was made for, as with my other comment I don't think it should stop this PR from being merged. I do think, though, that we should make an improvement ticket if there isn't already one. The CSS classes and components are already created that follow the correct design pattern, so I wouldn't think this would be a very major undertaking.

const { locale } = this.props;
const isInPanel = locale === 'panel';
const isInHub = locale === 'hub';
Comment on lines 89 to +91

This comment has been minimized.

@Eden12345

Eden12345 Apr 24, 2020
Contributor

I know this wasn't added in this PR either, just wanted to point out that it's a rather confusing choice semantically to use "locale" for the variable name for which view we're in when we also have locales for translations.

@christophertino christophertino merged commit 6219402 into develop Apr 26, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-1960/fix branch Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants