Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1969 Update Promo Modal Copy #536

Merged
merged 1 commit into from Apr 27, 2020
Merged

GH-1969 Update Promo Modal Copy #536

merged 1 commit into from Apr 27, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Apr 27, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Add exclamation point to Plus Promo modal copy
@benstrumeyer
Add exclamation point to promo copy
Loading status checks…
99153cb
@benstrumeyer benstrumeyer added this to the 8.5.0 milestone Apr 27, 2020
@benstrumeyer benstrumeyer requested a review from Eden12345 Apr 27, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner Apr 27, 2020
@benstrumeyer benstrumeyer self-assigned this Apr 27, 2020
@Eden12345
Eden12345 approved these changes Apr 27, 2020
View changes
@christophertino christophertino merged commit 65be54b into develop Apr 27, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the promo-copy-update branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eden12345 Eden12345

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @Eden12345 @christophertino