Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2038 Update Plus Feature List #540

Merged
merged 3 commits into from May 22, 2020
Merged

GH-2038 Update Plus Feature List #540

merged 3 commits into from May 22, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Apr 30, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Change the bullet point in Subscription Details panel from "Dark Blue Theme" to "Custom Themes"

Ticket: https://cliqztix.atlassian.net/browse/GH-2038
@benstrumeyer
Change the bullet point in Subscription Details panel from dark blue …
Loading status checks…
1d9f248 
…theme to custom themes
@benstrumeyer
Merge branch 'develop' into GH-2038
Loading status checks…
160f38b
@benstrumeyer benstrumeyer added this to the 8.5.1 milestone Apr 30, 2020
@benstrumeyer benstrumeyer requested review from wlycdgr and Eden12345 Apr 30, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner Apr 30, 2020
@benstrumeyer benstrumeyer self-assigned this Apr 30, 2020
@wlycdgr
wlycdgr reviewed Apr 30, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

Are we still using the subscription_dark_blue_theme locale string somewhere else, or can it be deleted?
@Eden12345
Eden12345 approved these changes May 1, 2020
View changes
@Eden12345
Copy link
Contributor

@Eden12345 Eden12345 commented May 1, 2020 •
edited

@wlycdgr It's being used on line 26 of SubscriptionThemes.jsx
@Eden12345 Eden12345 changed the title GH-2038 Update Plus Theme List GH-2038 Update Plus Feature List May 1, 2020
@christophertino christophertino removed this from the 8.5.1 milestone May 20, 2020
@benstrumeyer benstrumeyer reopened this May 22, 2020
@christophertino christophertino added this to the 8.5.1 milestone May 22, 2020
@christophertino
Merge branch 'develop' into GH-2038
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
5c8c7de
@christophertino christophertino merged commit cd3f6f1 into develop May 22, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2038 branch May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

@Eden12345 Eden12345

Assignees

@benstrumeyer benstrumeyer

Labels
None yet
Projects
None yet
Milestone
8.5.1
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@benstrumeyer @Eden12345 @wlycdgr @christophertino