Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2046 Update Account Creation Panel #541

Merged
merged 3 commits into from Jun 15, 2020
Merged

GH-2046 Update Account Creation Panel #541

merged 3 commits into from Jun 15, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented May 1, 2020 •
edited

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@benstrumeyer
Update account creation panel with premium benefits
Loading status checks…
f89d006
@benstrumeyer benstrumeyer added this to the 8.5.1 milestone May 1, 2020
@benstrumeyer benstrumeyer requested review from wlycdgr and Eden12345 May 1, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner May 1, 2020
@benstrumeyer benstrumeyer self-assigned this May 1, 2020
@wlycdgr
wlycdgr approved these changes May 1, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment •
edited

LGTM - just that hover transition we talked about
@benstrumeyer benstrumeyer modified the milestones: 8.5.1, 8.5.2 May 5, 2020
@benstrumeyer
Merge branch 'develop' into GH-2046
Loading status checks…
584ac0d
@christophertino
christophertino requested changes Jun 15, 2020
View changes
manifest.json Outdated Show resolved Hide resolved
@benstrumeyer
Fix manifest.json
Loading status checks…
05cdcab
@christophertino
christophertino approved these changes Jun 15, 2020
View changes
@christophertino christophertino merged commit 887fec5 into develop Jun 15, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2046 branch Jun 15, 2020
@benstrumeyer benstrumeyer removed this from the 8.5.2 milestone Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@wlycdgr wlycdgr

@Eden12345 Eden12345

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Feature Enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @christophertino @wlycdgr