Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation fixes for 8.5.0 #544

Merged
merged 6 commits into from May 5, 2020
Merged

Translation fixes for 8.5.0 #544

merged 6 commits into from May 5, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented May 5, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Address fitment issues for 8.5.0 translations
  • Fix caret bug in detailed tracker view
benstrumeyer added 5 commits May 5, 2020
@benstrumeyer
Vertically align description in spring promo modal. Change links to 1…
Loading status checks…
84fe973 
…2px to fix breakage in Russian
@benstrumeyer
Remove unused css class
Loading status checks…
1b876e8
@benstrumeyer
Spring promo modal text links use space-around
Loading status checks…
7813a07
@benstrumeyer
Change caret orientation
Loading status checks…
fa69d80
@benstrumeyer
Remove more unused css
Loading status checks…
8ebad49
@benstrumeyer benstrumeyer requested review from wlycdgr and ghostery/ghostery as code owners May 5, 2020
@benstrumeyer
Fix caret
Loading status checks…
792e3c3
@wlycdgr
wlycdgr approved these changes May 5, 2020
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM
@benstrumeyer benstrumeyer added this to the 8.5.0 milestone May 5, 2020
@benstrumeyer benstrumeyer self-assigned this May 5, 2020
@christophertino
christophertino approved these changes May 5, 2020
View changes
@christophertino christophertino merged commit 1786a97 into develop May 5, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the translations-fix branch May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
None yet
Projects
None yet
Milestone
8.5.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @christophertino @wlycdgr