Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation fixes for 8.5.0 #544

Merged
merged 6 commits into from May 5, 2020
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next

Vertically align description in spring promo modal. Change links to 1…

…2px to fix breakage in Russian
  • Loading branch information
benstrumeyer committed May 5, 2020
commit 84fe973c7f0668a107b04bee4d7877114be869c1
@@ -46,7 +46,7 @@ const PlusPromoModalContent = (props) => {
<span>{t('upgrade_to_plus').toUpperCase()}</span>
</button>
</div>
<div>
<div className="PlusPromoModal__text-link-container">
{!loggedIn &&
<span className="PlusPromoModal__link sign-in" onClick={handleSignInClick}>{t('subscribe_pitch_sign_in_plus')}</span>
}
@@ -45,8 +45,10 @@ $condensed-font-family: Roboto Condensed, "Open Sans", "Helvetica Neue", Helveti
margin-top: 8px;
}
.description {
font-size: 18px;
margin-top: 16px;
height: 131px;
display: flex;
align-items: center;
font-size: 15px;
font-weight: 500;
color: $tundora;
width: 350px;
@@ -158,26 +160,14 @@ $condensed-font-family: Roboto Condensed, "Open Sans", "Helvetica Neue", Helveti

.PlusPromoModal__text-link-container {
display: flex;
justify-content: space-around; // Edge does not support space-evenly
justify-content: space-evenly; // Edge does not support space-evenly
}

.PlusPromoModal__link {
margin-left: 10px;
margin-right: 10px;
font-size: 15px;
font-size: 12px;
font-family: $standard-font-family;
color: #4a4a4a;
text-decoration: underline;
text-align: center;
cursor: pointer;

&.sign-in {
float: left;
left: 10px;
}

&.turn-promos-off {
float: right;
right: 10px;
}
}
ProTip! Use n and p to navigate between commits in a pull request.