Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2022 Make radio button labels one line #545

Merged
merged 1 commit into from May 6, 2020
Merged

GH-2022 Make radio button labels one line #545

merged 1 commit into from May 6, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented May 6, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • This PR addresses translation kickbacks on GH-2022 where the radio button labels should be on one line
  • Radio buttons are used in the theme view for Plus subscribers and the Ad blocker lists view in Settings

Ticket: https://cliqztix.atlassian.net/browse/GH-2022

@benstrumeyer benstrumeyer added this to the 8.5.0 milestone May 6, 2020
@benstrumeyer benstrumeyer requested a review from wlycdgr May 6, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner May 6, 2020
@benstrumeyer benstrumeyer self-assigned this May 6, 2020
@wlycdgr
wlycdgr approved these changes May 6, 2020
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM

@christophertino christophertino merged commit 0b5f533 into develop May 6, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2022 branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants