Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-2048: Display premium icons & subscription info & GH-2036: Unlock Plus features on GBE/Midnight for all Premium & Plus users #546
GH-2048: Display premium icons & subscription info & GH-2036: Unlock Plus features on GBE/Midnight for all Premium & Plus users #546
Changes from 1 commit
901c4faf944c6ce035e69659749b2a83d42de02e6c53378f0a10bd6c7e552d2eb438329eb39bd2d2aa909383ab6f7b36a9f545e7b2fcc862ef915474fc3f532a9ffcbf120d4d7fe5a2433c506a0586ff5a77797c18167640847e49d25d313c9ad1de6398be1eb337bc3d51fd023e5eb749eb74947f1cd5ead0930File filter
Jump to
Rename subscriptionsPlus and subscriptionsPremium to plusAccess and p…
wlycdgrMay 13, 2020
Member
Can we rename this and the matching
_plusSubscriberhelper to reflect that they now return access status rather than subscription status?benstrumeyerMay 13, 2020
Author
Contributor
Changed to
_hasPlusAccess()and_hasPremiumAccess()!wlycdgrMay 13, 2020
Member
While you're in there, can you destructure
this.props.userlike you've done elsewhere?benstrumeyerMay 13, 2020
Author
Contributor
Done!
wlycdgrMay 13, 2020
Member
Similarly, let's rename this helper to
_hasPlusAccessbenstrumeyerMay 13, 2020
Author
Contributor
Renamed!