Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2051: Update (remove) In-App Plus/Premium pricing #547

Merged
merged 7 commits into from May 20, 2020
Merged

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented May 11, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

Remove pricing in:

  • In-App Plus Promo Panel
  • Intro Hub Plus Tab
  • The $2 tag next to Get Ghostery Plus tab in the Hub
  • The upsell popup in the Historical Stats view
  • Subscription Tab (no active subscriptions) is handled in account-web https://github.com/ghostery/account-web/pull/91
  • Spring Plus Promo is already updated
@benstrumeyer benstrumeyer added this to the 8.5.1 milestone May 11, 2020
@benstrumeyer benstrumeyer requested review from wlycdgr and Eden12345 May 11, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner May 11, 2020
@benstrumeyer benstrumeyer self-assigned this May 11, 2020
Copy link
Member

@wlycdgr wlycdgr left a comment

I'm still seeing the $2 price in a couple spots:

  • The Get Ghostery Plus tab in the Hub
  • The upsell popup in the HIstorical Stats view
@benstrumeyer benstrumeyer requested a review from wlycdgr May 12, 2020
@@ -1949,7 +1949,7 @@
"message": "No, Keep History"
},
"panel_stats_pitch_modal_text": {
"message": "Unlock your historical stats (and other cool perks) by upgrading to Ghostery Plus for $SPAN_START$$2/month.$SPAN_END$$LINK_START$Learn More$LINK_END$",
"message": "Unlock your historical stats (and other cool perks) by upgrading to Ghostery Plus$LINK_START$Learn More$LINK_END$",

This comment has been minimized.

@wlycdgr

wlycdgr May 12, 2020
Member

Can you add the period back in?

This comment has been minimized.

@benstrumeyer

benstrumeyer May 13, 2020
Author Contributor

Added back in--I still can't believe you caught that

@benstrumeyer benstrumeyer requested a review from wlycdgr May 13, 2020
Copy link
Member

@wlycdgr wlycdgr left a comment

LGTM

@christophertino christophertino merged commit 602956f into develop May 20, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2051 branch May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants