Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2051: Update (remove) In-App Plus/Premium pricing #547

Merged
merged 7 commits into from May 20, 2020
+4 −26
Merged

GH-2051: Update (remove) In-App Plus/Premium pricing #547

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a96829a
Update pricing in Plus Promotional Panel and Intro Hub Plus Tab
benstrumeyer May 11, 2020
b44b3e3
Remove $2 price tag in intro hub
benstrumeyer May 12, 2020
68358fe
Update tests
benstrumeyer May 12, 2020
88805ef
Remove $2 price tag in historical stats pitch modal
benstrumeyer May 12, 2020
03c3605
Add period back in
benstrumeyer May 13, 2020
565677c
Remove newline
benstrumeyer May 13, 2020
27cc2b6
Merge branch 'develop' into GH-2051
christophertino May 20, 2020
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev Next
Loading status checks…

Remove $2 price tag in historical stats pitch modal

  • Loading branch information
@benstrumeyer
benstrumeyer committed May 12, 2020
commit 88805ef7a81eda4dcc0005287ef57dd933dcd639
2 _locales/en/messages.json
View file
Open in desktop
@@ -1949,7 +1949,7 @@
"message": "No, Keep History"
},
"panel_stats_pitch_modal_text": {
"message": "Unlock your historical stats (and other cool perks) by upgrading to Ghostery Plus for $SPAN_START$$2/month.$SPAN_END$$LINK_START$Learn More$LINK_END$",
"message": "Unlock your historical stats (and other cool perks) by upgrading to Ghostery Plus$LINK_START$Learn More$LINK_END$",

This comment has been minimized.

Sign in to view
@wlycdgr

wlycdgr May 12, 2020
Member

Can you add the period back in?

This comment has been minimized.

Sign in to view
@benstrumeyer

benstrumeyer May 13, 2020
Author Contributor

Added back in--I still can't believe you caught that
"placeholders": {
"span_start": {
"content": "<span>"
ProTip! Use n and p to navigate between commits in a pull request.