Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2051: Update (remove) In-App Plus/Premium pricing #547

Merged
merged 7 commits into from May 20, 2020
Merged
@@ -1600,7 +1600,7 @@
"message": "Resolve issues fast with our Priority help desk service - and more perks to come"
},
"hub_supporter_manifesto": {
"message": "We strive to deliver the best privacy protection services to our users free of cost. While we do not charge for our privacy suite, you may choose to support us through a small monthly subscription. Join us in our mission by upgrading to Ghostery Plus - and unlock cool perks along the way!"
"message": "We strive to deliver the best privacy protection services to our users free of cost. While we do not charge for our browser extension, you may choose to support us through a small monthly subscription. Join us in our mission by upgrading to Ghostery Plus - and unlock cool perks along the way!"
},
"hub_supporter_feature_theme_description": {
"message": "Customize the Ghostery colors for a new visual experience! Introduced through popular request. Check out our special Dark Blue theme, and more to come."
@@ -1815,7 +1815,7 @@
"message": "Themes"
},
"subscribe_pitch": {
"message": "While Ghostery is free, you can choose to support us through a small subscription of $2 per month in exchange for cool perks, such as color themes, priority help service, and more. Join our mission and subscribe!"
"message": "While Ghostery is free, you can choose to support us through a small monthly subscription in exchange for special perks like color themes, personal tracking statistics, and more. Join our mission and subscribe!"
},
"subscribe_pitch_spring": {
"message": "Like what we do? Support us and unlock new spring themes, personal tracking insights, and other special perks by upgrading to Ghostery Plus!"
@@ -1949,7 +1949,7 @@
"message": "No, Keep History"
},
"panel_stats_pitch_modal_text": {
"message": "Unlock your historical stats (and other cool perks) by upgrading to Ghostery Plus for $SPAN_START$$2/month.$SPAN_END$$LINK_START$Learn More$LINK_END$",
"message": "Unlock your historical stats (and other cool perks) by upgrading to Ghostery Plus.$LINK_START$Learn More$LINK_END$",
"placeholders": {
"span_start": {
"content": "<span>"
@@ -63,10 +63,6 @@ class PlusView extends Component {
</div>
<div className="PlusView__costContainer flex-container align-middle align-justify">
{this._renderButton()}
<div
className="PlusView__headingCost flex-container align-middle"
dangerouslySetInnerHTML={{ __html: t('hub_supporter_price') }}
/>
</div>
</div>
</div>
@@ -31,7 +31,7 @@
}
.PlusView__costContainer {
margin: 0 auto;
max-width: 382px;
max-width: 182px;
}
.PlusView__button {
min-width: 180px;
@@ -56,7 +56,6 @@ describe('app/hub/Views/PlusView component', () => {
expect(component.find('.PlusView__headingImage').length).toBe(1);
expect(component.find('.PlusView__headingTitle').length).toBe(5);
expect(component.find('.PlusView__headingDescription').length).toBe(5);
expect(component.find('.PlusView__headingCost').length).toBe(1);
expect(component.find('.PlusView__perk').length).toBe(3);
expect(component.find('.PlusView__perkIcon').length).toBe(3);
expect(component.find('.PlusView__perkTitle').length).toBe(3);
@@ -31,14 +31,6 @@ exports[`app/hub/Views/PlusView component Snapshot tests with react-test-rendere
>
already_subscribed
</div>
<div
className="PlusView__headingCost flex-container align-middle"
dangerouslySetInnerHTML={
Object {
"__html": "hub_supporter_price",
}
}
/>
</div>
</div>
</div>
@@ -368,14 +360,6 @@ exports[`app/hub/Views/PlusView component Snapshot tests with react-test-rendere
>
get_ghostery_plus
</a>
<div
className="PlusView__headingCost flex-container align-middle"
dangerouslySetInnerHTML={
Object {
"__html": "hub_supporter_price",
}
}
/>
</div>
</div>
</div>
@@ -41,7 +41,6 @@ export function toggleOffersEnabled(enabled) {
};
}


// TODO the reducer calls getRewardMessage
// determine whether it would be better to simply call getRewardMessage directly where sendSignal is called
// (both since reducers are not supposed to have side effects and also because...why the extra complexity?)
ProTip! Use n and p to navigate between commits in a pull request.