Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIS-628: Display Too Many Password Reset Emails Sent #548

Merged
merged 4 commits into from Jun 15, 2020

Conversation

@afranco07
Copy link
Contributor

@afranco07 afranco07 commented May 11, 2020

Jira: GIS-628
Depends on: https://github.com/ghostery/auth/pull/32

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

When a user requests too many password reset emails (limit is 3 reset emails/hour), we stop sending the reset emails and the server returns status code 429 Too Many Requests.

This PR displays the appropriate message instead of the default server error message We seem to be having a technical issue. Try again later.

Screen Shot 2020-05-11 at 5 18 55 PM

@afranco07 afranco07 marked this pull request as ready for review May 22, 2020
@afranco07 afranco07 requested a review from ghostery/ghostery as a code owner May 22, 2020
@christophertino christophertino modified the milestones: 8.5.1, 8.5.2 May 27, 2020
@christophertino christophertino merged commit ce570f4 into develop Jun 15, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GIS-628/too-many-password-resets branch Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants