Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linter & Remove Unsafe React Lifecycle Events #552

Closed
wants to merge 13 commits into from

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented May 19, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
    • All but one. Will discuss

From Jira Cleanup Ticket (that I don't have access to):

  1. Clean up eslintrc.js:
  • In eslintrc.js, enable any checks marked with TODOs and fix associated code warnings.
  • Additionally remove template-curly-spacing and enable class-methods-use-this, no-mixed-operators, import/prefer-default-export.
  1. In React components, search for any life-cycle events marked with UNSAFE_ and refactor to use new React events.
@IAmThePan IAmThePan requested review from christophertino, Eden12345, jsignanini, wlycdgr, zarembsky and ghostery/ghostery as code owners May 19, 2020
@IAmThePan IAmThePan closed this May 19, 2020
@IAmThePan
Copy link
Contributor Author

@IAmThePan IAmThePan commented May 19, 2020

Wrong branch. Want to merge my Unsafe branch

@IAmThePan IAmThePan deleted the IAmThePan:feature/update-linter branch May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant