Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linter & Remove Unsafe React Lifecycle Events #552

Closed
wants to merge 13 commits into from
Closed
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Merge branch 'develop' into feature/update-linter

  • Loading branch information
IAmThePan committed May 12, 2020
commit 227d0127cd22be433fc279ef0f96ed9589544a6a
@@ -173,19 +173,6 @@ const Click2PlayContentScript = (function(win, doc) {
sendResponse();
return false;
});

window.addEventListener('load', () => {
const app_ids = Object.keys(C2P_DATA);
for (let i = 0; i < app_ids.length; i++) {
const app_id = app_ids[i];
if (Object.prototype.hasOwnProperty.call(C2P_DATA, app_id)) {
if (C2P_DATA[app_id].length >= 3) {
applyC2P(C2P_DATA[app_id][0], C2P_DATA[app_id][1], C2P_DATA[app_id][2]);
}
}
}
// TODO clear C2P_DATA to free memory
}, { capture: false, passive: true });
};

// Public API
@@ -880,7 +880,7 @@ class EventHandlers {
*
*/
static _resetNotifications() {
globals.C2P_LOADED = globals.NOTIFICATIONS_LOADED = false; // eslint-disable-line no-multi-assign
globals.NOTIFICATIONS_LOADED = false;
}
}

@@ -60,8 +60,7 @@ export function buildC2P(details, app_id) {
}
const app_name = bugDb.db.apps[app_id].name;
const c2pHtml = [];
const tab_host = tabInfo.getTabInfo(tab_id, 'host');
const blacklisted = !!Policy.blacklisted(tab_host);
const blacklisted = !!Policy.blacklisted(tab.host);

// Generate the templates for each c2p definition (could be multiple for an app ID)
c2pApp.forEach((c2pAppDef) => {
You are viewing a condensed version of this merge commit. You can view the full changes here.
ProTip! Use n and p to navigate between commits in a pull request.