add linting for react/no-access-state-in-setstate and fix resulting l…

…inting errors

.eslintrc.js

@@ -86,7 +86,7 @@ module.exports = {
 		'react/jsx-indent': [1, 'tab'],
 		'react/jsx-indent-props': [1, 'tab'],
 		'react/jsx-props-no-spreading': [0], // TODO: enable this check
-		'react/no-access-state-in-setstate': [0], // TODO: enable this check
+		'react/no-access-state-in-setstate': [1],
 		'react/no-danger': [0],
 		'react/prop-types': [0],
 		'react/jsx-fragments': [1, 'element'],

app/licenses/License.jsx

@@ -33,7 +33,7 @@ class License extends React.Component {
 	 * Toggle expansion of a license full text.
 	 */
 	toggleLicenseText() {
-		this.setState({ expanded: !this.state.expanded });
+		this.setState(prevState => ({ expanded: !prevState.expanded }));
 	}
 
 	/**

app/panel-android/components/content/Accordion.jsx

@@ -99,9 +99,9 @@ export default class Accordion extends React.Component {
 		const boundingRect = accordionContentNode.getBoundingClientRect();
 		// Try lo load more when needed
 		if (scrollTop + window.innerHeight - (accordionContentNode.offsetTop + boundingRect.height) > -needToUpdateHeight) {
-			const itemsLength = Math.min(this.state.currentItemsLength + this.nExtraItems, this.props.numTotal);
-			this.setState({
-				currentItemsLength: itemsLength,
+			this.setState((prevState) => {
+				const itemsLength = Math.min(prevState.currentItemsLength + this.nExtraItems, this.props.numTotal);
+				return { currentItemsLength: itemsLength };
 			});
 		}
 	}

app/panel/components/Blocking/BlockingHeader.jsx

@@ -186,7 +186,7 @@ class BlockingHeader extends React.Component {
 	 * @param {Object} event   	mouseclick event
 	 */
 	clickFilterText() {
-		this.setState({ filterMenuOpened: !this.state.filterMenuOpened });
+		this.setState(prevState => ({ filterMenuOpened: !prevState.filterMenuOpened }));
 	}
 
 	/**

app/panel/components/Blocking/GlobalTracker.jsx

@@ -47,7 +47,7 @@ class GlobalTracker extends React.Component {
 	 */
 	toggleDescription() {
 		const { tracker } = this.props;
-		this.setState({ showMoreInfo: !this.state.showMoreInfo });
+		this.setState(prevState => ({ showMoreInfo: !prevState.showMoreInfo }));
 
 		if (this.state.description) {
 			return;

app/panel/components/Blocking/Tracker.jsx

@@ -82,7 +82,7 @@ class Tracker extends React.Component {
 	 */
 	toggleDescription() {
 		const { tracker } = this.props;
-		this.setState({ showMoreInfo: !this.state.showMoreInfo });
+		this.setState(prevState => ({ showMoreInfo: !prevState.showMoreInfo }));
 
 		if (this.state.description) {
 			return;

app/panel/components/BuildingBlocks/ToggleSlider.jsx

@@ -50,9 +50,7 @@ class ToggleSlider extends React.Component {
 		if (typeof this.props.onChange === 'function') {
 			this.props.onChange(event);
 		} else {
-			this.setState({
-				checked: !this.state.checked,
-			});
+			this.setState(prevState => ({ checked: !prevState.checked }));
 		}
 	}
 

app/panel/components/DetailMenu.jsx

@@ -41,12 +41,14 @@ class DetailMenu extends React.Component {
 	 * @param {Object} event 		click event
 	 */
 	setActiveTab(event) {
-		const menu = { ...this.state.menu };
 		const selectionId = event.currentTarget.id;
-
-		Object.keys(menu).forEach((key) => { menu[key] = selectionId === key; });
 		sendMessage('ping', DetailMenu.pings[selectionId]);
-		this.setState({ menu });
+
+		this.setState((prevState) => {
+			const menu = { ...prevState.menu };
+			Object.keys(menu).forEach((key) => { menu[key] = selectionId === key; });
+			return { menu };
+		});
 	}
 
 	/**

app/panel/components/Header.jsx

@@ -65,7 +65,7 @@ class Header extends React.Component {
 	 * Handles toggling the drop-down pane open/closed
 	 */
 	toggleDropdown = () => {
-		this.setState({ dropdownOpen: !this.state.dropdownOpen });
+		this.setState(prevState => ({ dropdownOpen: !prevState.dropdownOpen }));
 	}
 
 	handleSignin = () => {

app/panel/components/Settings/TrustAndRestrict.jsx

@@ -43,15 +43,11 @@ class TrustAndRestrict extends React.Component {
 	 */
 	setActivePane(event) {
 		this.showWarning('');
-		const newMenuState = { ...this.state.menu };
-		Object.keys(newMenuState).forEach((key) => {
-			if (key === event.currentTarget.id) {
-				newMenuState[key] = true;
-			} else {
-				newMenuState[key] = false;
-			}
-		});
-		this.setState({ menu: newMenuState });
+		const menu = {
+			showTrustedSites: event.currentTarget.id === 'showTrustedSites',
+			showRestrictedSites: event.currentTarget.id === 'showRestrictedSites',
+		};
+		this.setState({ menu });
 	}
 
 	/**