Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Linter & Remove Unsafe React Lifecycle Events #553

Closed
wants to merge 15 commits into from
Closed

Update Linter & Remove Unsafe React Lifecycle Events #553

wants to merge 15 commits into from
+1,616 −1,351

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented May 19, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
    • All but one. Will discuss

From Jira Cleanup Ticket (that I don't have access to):

  1. Clean up eslintrc.js:
  • In eslintrc.js, enable any checks marked with TODOs and fix associated code warnings.
  • Additionally remove template-curly-spacing and enable class-methods-use-this, no-mixed-operators, import/prefer-default-export.
  1. In React components, search for any life-cycle events marked with UNSAFE_ and refactor to use new React events.
IAmThePan added 15 commits Apr 29, 2020
@IAmThePan
add linting for no-param-reassign and fix resulting linting errors
75b0091
@IAmThePan
add linting for prefer-object-spread and fix resulting linting errors
8d37082
@IAmThePan
add linting for no-restricted-syntax and fix 1/2 of resulting errors
3049bd1
@IAmThePan
add linting for no-prototype-builtins and fix resulting linting errors
fe03ad7
@IAmThePan
add linting for class-methods-use-this and fix most resulting errors.…
f11bc18 
… Add /tools and /tests to linter. Update height in UpgradeBanner
@IAmThePan
finish linting for class-methods-use-this
5f3471e
@IAmThePan
add linting for no-mixed-operators and fix resulting linting errors
d4d84dc
@IAmThePan
add linting for import/prefer-default-export and fix resulting lintin…
17f90ed 
…g errors
@IAmThePan
add linting for react/no-access-state-in-setstate and fix resulting l…
a77cd1b 
…inting errors
@IAmThePan
add linting for react/jsx-props-no-spreading and fix resulting lintin…
c31dbaf 
…g errors
@IAmThePan
finish linting errors for no-restricted-syntax. 1 remains: couldn't r…
3d50aff 
…esolve removing iterator loops for urlSearchParams
@IAmThePan
Merge branch 'develop' into feature/update-linter
227d012
@IAmThePan
Fix linting errors resulting from the merge with develop
Loading status checks…
0988a29
@IAmThePan
Refactor UNSAFE_componentWillMount into either constructor or compone…
b55be21 
…ntDidMount, leave notes for how decision was made.
@IAmThePan
Refactor UNSAFE_componentWillReceiveProps to componentDidUpdate or ge…
Loading status checks…
241747c 
…tDerivedStateFromProps
@IAmThePan IAmThePan requested review from christophertino, Eden12345, jsignanini, wlycdgr, zarembsky and ghostery/ghostery as code owners May 19, 2020
@IAmThePan
Copy link
Contributor Author

@IAmThePan IAmThePan commented May 26, 2020

Closing in favor of Pull Request 559:
#559
@IAmThePan IAmThePan closed this May 26, 2020
@IAmThePan IAmThePan deleted the IAmThePan:feature/remove-unsafe branch May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@Eden12345 Eden12345

@jsignanini jsignanini

@wlycdgr wlycdgr

@zarembsky zarembsky

@ghostery/ghostery Ghostery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@IAmThePan