Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Cleanup: Enforce Linting Rules & Update UNSAFE_ React Lifecycle Events #559

Merged
merged 33 commits into from Jun 4, 2020
Merged

Code Cleanup: Enforce Linting Rules & Update UNSAFE_ React Lifecycle Events #559

merged 33 commits into from Jun 4, 2020
+3,808 −3,126

Commits on Apr 29, 2020

  1. add linting for no-param-reassign and fix resulting linting errors

    @IAmThePan
    IAmThePan committed Apr 29, 2020
    75b0091

  2. add linting for prefer-object-spread and fix resulting linting errors

    @IAmThePan
    IAmThePan committed Apr 29, 2020
    8d37082

Commits on May 1, 2020

  1. add linting for no-restricted-syntax and fix 1/2 of resulting errors

    @IAmThePan
    IAmThePan committed May 1, 2020
    3049bd1

Commits on May 4, 2020

  1. add linting for no-prototype-builtins and fix resulting linting errors

    @IAmThePan
    IAmThePan committed May 4, 2020
    fe03ad7

Commits on May 5, 2020

  1. add linting for class-methods-use-this and fix most resulting errors.… 

    … Add /tools and /tests to linter. Update height in UpgradeBanner
    @IAmThePan
    IAmThePan committed May 5, 2020
    f11bc18

Commits on May 6, 2020

  1. finish linting for class-methods-use-this

    @IAmThePan
    IAmThePan committed May 6, 2020
    5f3471e

  2. add linting for no-mixed-operators and fix resulting linting errors

    @IAmThePan
    IAmThePan committed May 6, 2020
    d4d84dc

Commits on May 8, 2020

  1. add linting for import/prefer-default-export and fix resulting lintin… 

    …g errors
    @IAmThePan
    IAmThePan committed May 8, 2020
    17f90ed

  2. add linting for react/no-access-state-in-setstate and fix resulting l… 

    …inting errors
    @IAmThePan
    IAmThePan committed May 8, 2020
    a77cd1b

Commits on May 11, 2020

  1. add linting for react/jsx-props-no-spreading and fix resulting lintin… 

    …g errors
    @IAmThePan
    IAmThePan committed May 11, 2020
    c31dbaf

Commits on May 12, 2020

  1. finish linting errors for no-restricted-syntax. 1 remains: couldn't r… 

    …esolve removing iterator loops for urlSearchParams
    @IAmThePan
    IAmThePan committed May 12, 2020
    3d50aff

  2. Merge branch 'develop' into feature/update-linter

    @IAmThePan
    IAmThePan committed May 12, 2020
    227d012

  3. Fix linting errors resulting from the merge with develop

    @IAmThePan
    IAmThePan committed May 12, 2020
    0988a29

Commits on May 14, 2020

  1. Refactor UNSAFE_componentWillMount into either constructor or compone… 

    …ntDidMount, leave notes for how decision was made.
    @IAmThePan
    IAmThePan committed May 14, 2020
    b55be21

Commits on May 18, 2020

  1. Refactor UNSAFE_componentWillReceiveProps to componentDidUpdate or ge… 

    …tDerivedStateFromProps
    @IAmThePan
    IAmThePan committed May 18, 2020
    241747c

Commits on May 20, 2020

  1. re-enable lint exception for no-prototype-builtins and revert calls b… 

    …ack to hasOwnProperty
    @IAmThePan
    IAmThePan committed May 20, 2020
    eb413fb

  2. add single line exception for no-restricted-syntax linting rule

    @IAmThePan
    IAmThePan committed May 20, 2020
    ac0ec93

Commits on May 21, 2020

  1. add linting for react/destructuring-assignment and fix errors. ToDo: … 

    …test code and check for errors
    @IAmThePan
    IAmThePan committed May 21, 2020
    fd954eb

Commits on May 22, 2020

  1. Fix minor bugs

    @IAmThePan
    IAmThePan committed May 22, 2020
    e815546

  2. Fix General Settings last updated text

    @IAmThePan
    IAmThePan committed May 22, 2020
    ae8ffcc

Commits on May 23, 2020

  1. rework linting rule no-param-reassign to have more exceptions and par… 

    …am object destructuring
    @IAmThePan
    IAmThePan committed May 23, 2020
    4c56460

Commits on May 26, 2020

  1. Remove file and line linting exceptions.

    @IAmThePan
    IAmThePan committed May 26, 2020
    c5ef663

  2. re-add linting rule react/sort-comp and fix resulting errors

    @IAmThePan
    IAmThePan committed May 26, 2020
    3ca2402

  3. remove added linting exception consistent-return and fix resulting er… 

    …rors
    @IAmThePan
    IAmThePan committed May 26, 2020
    4533fd7

  4. remove added linting expression no-use-before-define and fix resultin… 

    …g errors. fix BugDB.js bug.
    @IAmThePan
    IAmThePan committed May 26, 2020
    590aa60

  5. Fix linting error

    @IAmThePan
    IAmThePan committed May 26, 2020
    ecb62e8

  6. fix minor bugs

    @IAmThePan
    IAmThePan committed May 26, 2020
    f634c1d

  7. Code cleanup: fix PromoModal imports

    @IAmThePan
    IAmThePan committed May 26, 2020
    ea51432

  8. Merge with develop. Fix resulting linting errors

    @IAmThePan
    IAmThePan committed May 26, 2020
    75a88cb

Commits on May 28, 2020

  1. remove unnecessary hasOwnProperty calls after refactored for...in loops

    @IAmThePan
    IAmThePan committed May 28, 2020
    68493d2

  2. Fix missing strings bug

    @IAmThePan
    IAmThePan committed May 28, 2020
    6297062

  3. Fix last remaining string bug

    @IAmThePan
    IAmThePan committed May 28, 2020
    9b4d16c

Commits on Jun 4, 2020

  1. Merge branch 'develop' into feature/cleanup

    @IAmThePan
    IAmThePan committed Jun 4, 2020
    2cb47a1