Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Cleanup: Enforce Linting Rules & Update UNSAFE_ React Lifecycle Events #559
Code Cleanup: Enforce Linting Rules & Update UNSAFE_ React Lifecycle Events #559
Changes from 1 commit
75b00918d370823049bd1fe03ad7f11bc185f3471ed4d84dc17f90eda77cd1bc31dbaf3d50aff227d0120988a29b55be21241747ceb413fbac0ec93fd954ebe815546ae8ffcc4c56460c5ef6633ca24024533fd7590aa60ecb62e8f634c1dea5143275a88cb68493d262970629b4d16c2cb47a1File filter
Jump to
Fix General Settings last updated text
wlycdgrJun 4, 2020
Member
Was this just a bug where
bugs_last_checkedandbugs_last_updatedwere not being included in the action object when they always should have been?IAmThePanJun 11, 2020
Author
Contributor
Yes, I noticed a bug where after clicking to update the Ghostery tracker library the "Update Now" link text would change to "Still up-to-date" but the timestamp would remain the same until you reopened the panel. Only when you reopened the panel would the timestamp change to when you last clicked the update link. I fixed it so the timestamp changes when you click to get the update.
I also had to modify src/background.js#checkLibraryVersion to send the relevant
confDatain theresolveobject.There may have been a few files changed in relation to this bug fix. Search for
bugs_last_checkedandbugs_last_updatedto find them.wlycdgrJun 11, 2020
Member
I did see a bunch of the other changes, yeah. Cool, thanks for fixing & explaining!