Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to find missing tokens #563

Merged

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Jun 4, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

I created a tool to search the extension for translation tokens and check to make sure those tokens are in the default messages.json file.
Run the tool by running node tools/token-checker.js.
Requires one new package under dev dependencies: find-in-files.

This tool does NOT work for tokens that are formed using variable names:

  • t('global_settings_saved_category')
  • ✘ t(alert_${type}_off)
@IAmThePan IAmThePan requested review from Eden12345 and ghostery/ghostery as code owners Jun 4, 2020
@IAmThePan IAmThePan changed the title Feature/missing token tool ii Add script to find missing tokens Jun 4, 2020
@christophertino christophertino added this to the 8.5.2 milestone Jun 15, 2020
@christophertino christophertino merged commit 0093250 into ghostery:develop Jun 15, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@IAmThePan IAmThePan deleted the IAmThePan:feature/missing-token-tool-ii branch Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants