Remove Refactoring notes from feature/cleanup and address PR comments #566
+96
−228
Conversation
|
LGTM so far. This obviates my comments re: these in the original linting PR. Will review the other changes. |
|
I tried restoring |
|
Looks good so far. Will review again once the last batch of comments from the original PR has been addressed (files from |
|
I addressed all the outstanding comments on the Code Cleanup PR. Please review. |
|
LGTM! Thank you for fixing the banner bug along the way! |
51d737e
into
ghostery:develop
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I removed all the notes I made when refactoring UNSAFE_ lifecycle events.
@christophertino Did you want to remove linting rules that are now set to 0 from .eslintrc.js?