Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/console debugging #568

Merged
merged 155 commits into from Sep 24, 2020

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Jun 16, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

I created a window.GHOSTERY object for debugging purposes.

There are 2 ways you can find this information:

  1. Open the background.js console from chrome://extensions. Call window.GHOSTERY.getTabInfo() to populate the foundBugs and tabInfo objects. Call window.GHOSTERY.getUserData() to populate the user object.
  2. Open the extension, click the menu, and click Help. Click the "Help for Ghostery Browser Extension" text five times (like how you enable developer mode on Android). An "Open Debug Information" link will appear, click on that. A new tab will open at app/templates/debug_information.html. This will run both getTabInfo() and getUserData() to populate the window.GHOSTERY object. It will then output the object in JSON to the page and download the JSON as a file.

Option 1 is meant for to be used by developers wanting debug information as they build the extension. Option 2 is meant for users who run into issues so they can send concise, relevant information to the Ghostery support team.
For Option 2, I don't expect we will both show a JSON web file and download the file; I wanted to showcase the options.

IAmThePan added 30 commits Apr 29, 2020
… Add /tools and /tests to linter. Update height in UpgradeBanner
…esolve removing iterator loops for urlSearchParams
…ntDidMount, leave notes for how decision was made.
…tDerivedStateFromProps
wlycdgr and others added 20 commits Sep 23, 2020
…tery-extension into feature/console-debugging
…s as it is only intended for use with functions defined with the async keyword
… a closure to force JSDoc to document inner properties
@christophertino
Copy link
Member

@christophertino christophertino commented Sep 24, 2020

Relates to #43. This will allow users to debug account events in the console with ghostery.getUserData()

@christophertino christophertino merged commit 0781353 into ghostery:develop Sep 24, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@christophertino christophertino deleted the IAmThePan:feature/console-debugging branch Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants