Feature/console debugging #568
Merged
+1,537
−67
Conversation
… Add /tools and /tests to linter. Update height in UpgradeBanner
…esolve removing iterator loops for urlSearchParams
…ntDidMount, leave notes for how decision was made.
…tDerivedStateFromProps
…ack to hasOwnProperty
…test code and check for errors
…am object destructuring
…g errors. fix BugDB.js bug.
…tery-extension into feature/console-debugging
…s as it is only intended for use with functions defined with the async keyword
… a closure to force JSDoc to document inner properties
|
Relates to #43. This will allow users to debug account events in the console with |
0781353
into
ghostery:develop
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I created a
window.GHOSTERYobject for debugging purposes.There are 2 ways you can find this information:
window.GHOSTERY.getTabInfo()to populate thefoundBugsandtabInfoobjects. Callwindow.GHOSTERY.getUserData()to populate theuserobject.getTabInfo()andgetUserData()to populate thewindow.GHOSTERYobject. It will then output the object in JSON to the page and download the JSON as a file.Option 1 is meant for to be used by developers wanting debug information as they build the extension. Option 2 is meant for users who run into issues so they can send concise, relevant information to the Ghostery support team.
For Option 2, I don't expect we will both show a JSON web file and download the file; I wanted to showcase the options.