Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross platform extension #569

Merged
merged 5 commits into from Jun 19, 2020
Merged

Cross platform extension #569

merged 5 commits into from Jun 19, 2020

Conversation

@sammacbeth
Copy link
Contributor

@sammacbeth sammacbeth commented Jun 16, 2020

Preparing for unified extension build for desktop and android:

  • Dynamic loading of modules based on platform
  • Include browser-core build with -lite modules included.
@sammacbeth sammacbeth changed the title Android extension Cross platform extension Jun 16, 2020
Launches info popup in a temporary webview, rather than a full tab.
export const HUMANWEB_MODULE = IS_ANDROID ? 'human-web-lite' : 'human-web';
export const HPN_MODULE = IS_ANDROID ? 'hpn-lite' : 'hpnv2';
// override the default prefs based on the platform
CLIQZ.config.default_prefs = {

This comment has been minimized.

@chrmod

chrmod Jun 17, 2020
Member

config.settings.HW_CHANNEL should be set to android for human-web-lite.

@chrmod
chrmod approved these changes Jun 18, 2020
@sammacbeth sammacbeth marked this pull request as ready for review Jun 18, 2020
@sammacbeth sammacbeth requested review from zarembsky and ghostery/ghostery as code owners Jun 18, 2020
src/background.js Show resolved Hide resolved
@christophertino christophertino added this to the 8.5.2 milestone Jun 19, 2020
@christophertino christophertino merged commit d86061b into ghostery:develop Jun 19, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants