Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1971: Replace spring promo with midnight promo in panel #571

Merged
merged 2 commits into from Jun 29, 2020
Merged

GH-1971: Replace spring promo with midnight promo in panel #571

merged 2 commits into from Jun 29, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Jun 26, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

Ticket: https://ghostery.atlassian.net/browse/GH-1971
@benstrumeyer
Replace spring promo modal with premium promo modal
Loading status checks…
a234a72
@benstrumeyer
Remove plus render
Loading status checks…
9137236
@benstrumeyer benstrumeyer added this to the 8.5.2 milestone Jun 26, 2020
@benstrumeyer benstrumeyer requested a review from wlycdgr Jun 26, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner Jun 26, 2020
@benstrumeyer benstrumeyer self-assigned this Jun 26, 2020
@wlycdgr
wlycdgr approved these changes Jun 26, 2020
View changes
@christophertino christophertino merged commit cc51d90 into develop Jun 29, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-1971 branch Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Feature Enhancement
Projects
None yet
Milestone
8.5.2
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @wlycdgr @christophertino