Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2072: 8.5.2 Metrics #576

Merged
merged 3 commits into from Jul 6, 2020
Merged

GH-2072: 8.5.2 Metrics #576

merged 3 commits into from Jul 6, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Jul 1, 2020 •
edited

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

Changes UTM params to the following:

  • Top Plus Button: utm_source=gbe&signedIn=0&st=-1&subscription_interval=year&utm_campaign=intro_hub_c_1
  • Bottom Plus Button: utm_source=gbe&signedIn=0&st=-1&subscription_interval=year&utm_campaign=intro_hub_c_2
  • Top Premium Button: utm_source=gbe&signedIn=0&st=-1&subscription_interval=year&utm_campaign=intro_hub_c_3
  • Bottom Premium Button: utm_source=gbe&signedIn=0&st=-1&subscription_interval=year&utm_campaign=intro_hub_c_4

Ticket: https://ghostery.atlassian.net/browse/GH-2072
@benstrumeyer
Refactor utm params and remove interval param
Loading status checks…
3bf86d1
@benstrumeyer benstrumeyer added this to the 8.5.2 milestone Jul 1, 2020
@benstrumeyer benstrumeyer requested a review from wlycdgr Jul 1, 2020
@benstrumeyer benstrumeyer self-assigned this Jul 1, 2020
benstrumeyer and others added 2 commits Jul 1, 2020
@benstrumeyer
Fix linting errors
Loading status checks…
b9aa339
@christophertino
Merge branch 'develop' into GH-2072
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
ed614f2
@christophertino
christophertino approved these changes Jul 6, 2020
View changes
@christophertino christophertino merged commit e8e64f9 into develop Jul 6, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2072 branch Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.2
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@benstrumeyer @christophertino