Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2109: Display error message on too many failed logins #577

Merged
merged 3 commits into from Aug 10, 2020

Conversation

@afranco07
Copy link
Contributor

@afranco07 afranco07 commented Jul 2, 2020

Jira: GH-2109

Depends on: https://github.com/ghostery/auth/pull/34

After 5 failed login attempts we lock the user out and prevent them from logging in for an hour. This PR adds an error that notifies the user that they have been locked out for an hour. The user can still request a forgot password email, and on a successful reset the user can attempt to login again.

Screen Shot 2020-07-02 at 4 37 08 PM

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
Alberto Franco and others added 2 commits Jul 2, 2020
@afranco07 afranco07 marked this pull request as ready for review Jul 24, 2020
@afranco07 afranco07 requested a review from ghostery/ghostery as a code owner Jul 24, 2020
@afranco07 afranco07 requested a review from christophertino Jul 24, 2020
@christophertino christophertino added this to the 8.5.3 milestone Jul 27, 2020
@christophertino christophertino merged commit e3f9ff8 into develop Aug 10, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2109/display-login-error branch Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants