Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2046: Blank detailed view #580

Merged
merged 4 commits into from Jul 14, 2020
Merged

GH-2046: Blank detailed view #580

merged 4 commits into from Jul 14, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Jul 13, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Addresses kickback in GH-2046 where a user creates an account and returns to the detailed view

Ticket: https://ghostery.atlassian.net/browse/GH-2046?focusedCommentId=17699

@benstrumeyer benstrumeyer added this to the 8.5.2 milestone Jul 13, 2020
@benstrumeyer benstrumeyer requested a review from wlycdgr Jul 13, 2020
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner Jul 13, 2020
@benstrumeyer benstrumeyer self-assigned this Jul 13, 2020
@benstrumeyer benstrumeyer changed the title GH-2046 GH-2046: Blank detailed view Jul 13, 2020
Copy link
Member

@wlycdgr wlycdgr left a comment

Looks good. Smoked it in the regular detailed and in the expanded detailed view and works in both.

@christophertino christophertino merged commit 67bc189 into develop Jul 14, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2046 branch Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants