Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2046: Blank detailed view #580

Merged
merged 4 commits into from Jul 14, 2020
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next

Fix detailed view

  • Loading branch information
benstrumeyer committed Jul 13, 2020
commit 5585ad682ffb2c255edfa0106af27640afc874b7
@@ -13,13 +13,14 @@

import React from 'react';
import { NavLink } from 'react-router-dom';
import PropTypes from 'prop-types';

/**
* @class Implement Account Success component which opens
* in place of Sign In view on successful signing.
* @memberof PanelClasses
*/
const AccountSuccess = ({ email }) => (
const AccountSuccess = ({ email, is_expert }) => (
<div id="signin-success-panel">
<div className="row align-center">
<div className="small-11 columns text-center">
@@ -31,7 +32,7 @@ const AccountSuccess = ({ email }) => (
<a className="learn-more-button" href="https://ghostery.com/midnight?utm_source=gbe&utm_campaign=in_app_account_creation_success" alt={t('learn_more')} target="_blank" rel="noopener noreferrer">
{t('learn_more')}
</a>
<NavLink className="no-thanks-maybe-later text-center" to="/">
<NavLink className="no-thanks-maybe-later text-center" to={is_expert ? '/detail' : '/'}>
{t('subscribe_pitch_no_thanks')}
</NavLink>
</div>
@@ -41,6 +42,7 @@ const AccountSuccess = ({ email }) => (

AccountSuccess.defaultProps = {
email: '',
is_expert: PropTypes.bool.isRequired,
};

export default AccountSuccess;
ProTip! Use n and p to navigate between commits in a pull request.