Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2090: 8.5.2 Translations kickbacks #582

Merged
merged 2 commits into from Jul 17, 2020
Merged

GH-2090: 8.5.2 Translations kickbacks #582

merged 2 commits into from Jul 17, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Jul 17, 2020 •
edited

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • Allow flexible CTA button width
  • Make table columns wider for large view
  • Move bullets slightly to the left

Ticket: https://ghostery.atlassian.net/browse/GH-2090
@benstrumeyer
Move card bullets slightly to the left. Allow flexible width for tabl…
008abdb 
…e buttons. Increase column size in table for large view
@benstrumeyer
Merge branch 'develop' into translations
Loading status checks…
e244e8d
@benstrumeyer benstrumeyer added this to the 8.5.2 milestone Jul 17, 2020
@benstrumeyer benstrumeyer requested a review from wlycdgr Jul 17, 2020
@benstrumeyer benstrumeyer requested review from christophertino, jsignanini, zarembsky and ghostery/ghostery as code owners Jul 17, 2020
@benstrumeyer benstrumeyer self-assigned this Jul 17, 2020
@benstrumeyer benstrumeyer changed the base branch from master to develop Jul 17, 2020
@wlycdgr
wlycdgr approved these changes Jul 17, 2020
View changes
@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Jul 17, 2020

looks like the least of many evils to me
@christophertino christophertino merged commit 5e572ec into develop Jul 17, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the translations branch Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

@christophertino christophertino

@jsignanini jsignanini

@zarembsky zarembsky

Assignees

@benstrumeyer benstrumeyer

Labels
Type: Bug
Projects
None yet
Milestone
8.5.2
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @wlycdgr @christophertino