Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2071/Hub-promo-abc-test #583

Merged
merged 9 commits into from Jul 20, 2020
Merged

GH-2071/Hub-promo-abc-test #583

merged 9 commits into from Jul 20, 2020

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Jul 20, 2020

Implements an A/B/C test for promotional approaches in the Hub so we can compare the performance of the new Upgrade Plan feature matrix view against previous strategies.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
wlycdgr added 8 commits Jun 3, 2020
@wlycdgr
Fetch hub promo ab test before opening hub on install. Add hub promo …
Loading status checks…
4fb0c4a 
…variant utm param. Add hub promo variant conf prop.
@wlycdgr
Opportunistic refactor of message handling in background.js
Loading status checks…
ce3230c
@wlycdgr
Revert "Opportunistic refactor of message handling in background.js"
Loading status checks…
b23bc6c 
This reverts commit ce3230c.
@wlycdgr
Do not overwrite hub_promo_variant prop after it is first set
Loading status checks…
33d4d20
@wlycdgr
Merge develop
Loading status checks…
0c3fef7
@wlycdgr
Fixes to satisfy new linter rules
Loading status checks…
61511e7
@wlycdgr
Display plain home view, home view with Premium modal, or new Upgrade…
Loading status checks…
75508b3 
… Plan view in Hub depending on A/B/C/ test bucket
@wlycdgr
Remove console statements
Loading status checks…
f607966
@wlycdgr wlycdgr requested review from jsignanini, zarembsky and ghostery/ghostery as code owners Jul 20, 2020
@wlycdgr wlycdgr changed the title Gh 2071/hub promo abc test GH-2071/Hub-promo-abc-test Jul 20, 2020
@wlycdgr wlycdgr requested review from christophertino and benstrumeyer Jul 20, 2020
@christophertino
christophertino approved these changes Jul 20, 2020
View changes
@christophertino christophertino added this to the 8.5.2 milestone Jul 20, 2020
@christophertino
Merge branch 'develop' into GH-2071/hub-promo-abc-test
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
f88c659
@benstrumeyer
benstrumeyer approved these changes Jul 20, 2020
View changes
Copy link
Contributor

@benstrumeyer benstrumeyer left a comment

LGTM
@christophertino christophertino merged commit 5a6ab2b into develop Jul 20, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2071/hub-promo-abc-test branch Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@benstrumeyer benstrumeyer

@jsignanini jsignanini

@zarembsky zarembsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.2
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@wlycdgr @christophertino @benstrumeyer